Revert "Revert "CI: Include stdlib build for Wasm in the Linux buildbot"" #77872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci build toolchain |
|
@swift-ci smoke test |
|
@swift-ci test webassembly |
|
@swift-ci smoke test |
|
@swift-ci test webassembly |
|
@swift-ci build toolchain |
MaxDesiatov
added
continuous integration
WebAssembly
|
@swift-ci test |
shahmishal
approved these changes
Dec 4, 2024
shahmishal
deleted the
revert-76597-revert-72010-yt/include-wasm-build-linux-buildbot
branch
MaxDesiatov
added a commit
that referenced
this pull request
Dec 5, 2024
* **Explanation**: "Swift Test Linux Platform" jobs on ci.swift.org required as PR checks should cross-compile and run tests for WebAssembly. Effectively, what was previously an optional `@swift-ci test webassembly` trigger should become an implicit and required part of PR testing to prevent occasional regressions in Wasm and WASI support. * **Scope**: Only affects the WASI platform * **Risk**: Low. It increases job run time by ~10% and this platform has active maintainers. * **Testing**: stdlib test suite is now enabled. * **Issue**: N/A * **Reviewer**: @shahmishal * **Main branch PR**: #77872
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #76597
After performance improvements landed in WasmKit, this no longer introduces a 1hr regression, but only 10-20 minutes slowdown to Ubuntu jobs.
Additional solutions are investigated to shave time off SwiftPM build jobs, which could potentially reduce total build time by 5-10 minutes in swiftlang/swift-package-manager#8145.